rpc: simplify/constify getnodeaddresses code

2021/4/7 アクティビティ

rpc: simplify/constify getnodeaddresses code

情報元 - rpc: simplify/constify getnodeaddresses code · bitcoin/[email protected] · GitHub

rpc: simplify/constify getnodeaddresses code · bitcoin/bitcoin@1b91898 · GitHub

フォローする

bitcoin, BTC, constify getnodeaddresses code, rpc, simplify 1of.biz

FreeBSD: Document Python 3 requirement for ‘gmake check’

<pre>FreeBSD: Document Python 3 requirement for 'gmake check'</pre>

記事を読む

rpc: factor out RpcInterruptionPoint from dumptxoutset

記事を読む

[doc] Add release notes for ‘account’ API removal

<pre>[doc] Add release notes for 'account' API removal</pre>

記事を読む

Use 71 byte signature for DUMMY_SIGNATURE_CREATOR

Use 71 byte signature for DUMMY_SIGNATURE_CREATOR Changes DUMMY_SIGNATURE_CREATOR to create 71 byte dummy signatures. Update comments to reflect this change

記事を読む

gui: Throttle GUI update pace when -reindex

gui: Throttle GUI update pace when -reindex Co-authored-by: Barry Deeney <[email protected]> Co-authored-by: Russell Yanofsky <[email protected]>

記事を読む

Fix incorrect tests

記事を読む

Merge #19250: wallet: Make RPC help compile-time static

Merge #19250: wallet: Make RPC help compile-time static fadf6bd04f002d05aaff8eba74015e25a41966bc refactor: Remove unused request.fHelp (MarcoFalke) fad889cbf0b6c46da2e110b73cbea55e4ff7951e wallet: Make RPC help compile-time static (MarcoFalke) ...

記事を読む

Merge #18288: build: Add MemorySanitizer (MSan) in Travis to detect u…

<pre>Merge #18288: build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory 870f0cd2a0534d54bba18190e9f024f88e832933 build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory (practicalswift) Pull request description: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory. First UBSan, then ASan followed by TSan... and now: yes, the wait is over -- **MSan is finally here!** :) Some historical context: * 2017: Continuous compilation with Clang Thread Safety analysis enabled (#10866, #10923) * 2018: Continuous testing with trapping on signed integer overflows (`-ftrapv`) (#12686) * 2018: Continuous testing of use of locale dependent functions (#13041) * 2018: Continuous testing of format strings (#13705) * 2018: Continuous compilation with MSVC `TreatWarningAsError` (#14151) * 2018: Continuous testing under UndefinedBehaviorSanitizer – UBSan (#14252, #14673, #17006) * 2018: Continuous testing under AddressSanitizer – ASan (#14794, #17205, #17674) * 2018: Continuous testing under ThreadSanitizer – TSan (#14829) * 2019: Continuous testing in an unsigned char environment (`-funsigned-char`) (#15134) * 2019: Continuous compile-time testing of assumptions we're making (#15391) * 2019: Continuous testing of fuzz test cases under Valgrind (#17633, #18159, #18166) * 2020: Finally... MemorySanitizer – MSAN! :) What is the next step? What tools should we add to CI to keep bugs from entering `master`? :) ACKs for top commit: MarcoFalke: ACK 870f0cd2a0534d54bba18190e9f024f88e832933 Tree-SHA512: 38327c8b75679d97d469fe42e704cacd1217447a5a603701dd8a58ee50b3be2c10248f8d68a479ed081c0c4b254589d3081c9183f991640b06ef689061f75578</pre>

記事を読む

build: enable -Wdocumentation if suppressing external warnings

build: enable -Wdocumentation if suppressing external warnings Co-authored-by: Ben Woosley <[email protected]>

記事を読む

Merge #18792: wallet: Remove boost from PeriodicFlush

<pre>Merge #18792: wallet: Remove boost from PeriodicFlush fa1c74fd0342b74d44cc4e41fff3890c1434e8f7 wallet: Remove unused boost::thread_interrupted (MarcoFalke) fa7b885f51ff848d3f913bc6e15d24528300c210 walletdb: Remove unsed boost/thread (MarcoFalke) 5555d978b056ab0e0e59faaf2d2067ec43fffaef wallet: Make PeriodicFlush uninterruptible (MarcoFalke) Pull request description: The `boost::this_thread::interruption_point()` in the code base currently block the replacement of `boost::thread` with `std::thread`. [1] Remove them from the wallet because they are either unused or useless. The feature to interrupt a periodic flush is useless because all wallets have just been flushed https://github.com/bitcoin/bitcoin/blob/9ccaee1d5e2e4b79b0a7c29aadb41b97e4741332/src/init.cpp#L194 and another flush should be a noop. Also, they will be flushed again shortly after https://github.com/bitcoin/bitcoin/blob/9ccaee1d5e2e4b79b0a7c29aadb41b97e4741332/src/init.cpp#L285, so even if repeated flushes weren't a noop, doing 3 instead of 2 shouldn't matter too much at this point. Also, the wallet is flushed every two seconds in the worst case, so if this is an expensive operation, that period should be readjusted. (Or bdb should be removed altogether #18916) [1] Replacement of `boost::thread` with `std::thread` should happen because: * The boost thread dependency is slow to compile * Boost thread is less maintained than the standard lib * Boost thread is mostly redundant to the standard lib * Global interruption points via exceptions are hard to keep track of during review and easy to get wrong during runtime (e.g. accidental `catch (...)`) ACKs for top commit: fanquake: ACK fa1c74fd0342b74d44cc4e41fff3890c1434e8f7 Tree-SHA512: b166619256de2ef4325480fa1367f68bc9371ad785ec503aed61eab41ba61f1a9807aab25451a24efda3db64855c9ba0025645b98bc58557bc3ec56c5b3297d0</pre>

記事を読む

rpc: add network field to rpc getnodeaddresses

rpc: improve getnodeaddresses help