Merge #21081: test: fix the unreachable code at feature_taproot

Merge #21081: test: fix the unreachable code at feature_taproot

5e0cd25e29541e6c19559fb5c2555e008ed896fa fix the unreachable code at feature_taproot (Bruno Garcia)

Pull request description:

  This PR removes the unnecessary return statement at the beginning of the function that makes the rest of the function unreachable.

ACKs for top commit:
  practicalswift:
    cr ACK 5e0cd25e29541e6c19559fb5c2555e008ed896fa: patch looks correct!
  sipa:
    ACK 5e0cd25e29541e6c19559fb5c2555e008ed896fa.
  theStack:
    Tested ACK 5e0cd25e29541e6c19559fb5c2555e008ed896fa 🏔️
  sanket1729:
    tACK 5e0cd25e29541e6c19559fb5c2555e008ed896fa. I noted this a while ago while fixing feature_taproot.py for elements. Verified that the extreme ranges of CScriptNum are correct and the overflow case for `CHECKSIGADD` works as intended. Adding 1 to 2^31 - 1 results in an overflow, but the interpreter puts a `vch` of corresponding to 2^31 on stack. Even though it cannot be converted to CscriptNum(restricted to 4 bytes), it's result can still be compared by OP_EQUAL.

Tree-SHA512: fff9be3be94f4b3f3ccf24bf588d96e84d14806f82692dccd31631b0e5c79a7575a96c308cb5a4f610ab02e2f854b899f374437c33ecf6d52055d333f2de9b27

情報元 - Merge #21081: test: fix the unreachable code at feature_taproot · bitcoin/[email protected] · GitHub

Merge #21081: test: fix the unreachable code at feature_taproot · bitcoin/bitcoin@cf26ca3 · GitHub
スポンサーリンク

シェアする

フォローする

スポンサーリンク

トップへ戻る