Merge #20927: [refactor] [net] Clean up InactivityCheck()

Merge #20927: [refactor] [net] Clean up InactivityCheck()

bf100f8170770544fb39ae6802175c564cde532f [net] Cleanup InactivityChecks() and add commenting about time (John Newbery)
06fa85cd50b718fecd69f0481740d2b8714a1397 [net] InactivityCheck() takes a CNode reference (John Newbery)

Pull request description:

  This is a pure refactor and should not change any behavior. It clarifies and documents the InactivityCheck() function

  This makes #20721 easier to review. In particular, this function uses a mixture of (unmockable) system time and mockable time. It's important to understand where those are being used when reviewing #20721.

  #20721 doesn't require this change, so if others don't agree that it's useful and makes review easier, then I'm happy to close this and just do #20721 directly.

ACKs for top commit:
  fanquake:
    ACK bf100f8170770544fb39ae6802175c564cde532f
  MarcoFalke:
    review ACK bf100f8170770544fb39ae6802175c564cde532f 💫

Tree-SHA512: 7b001de2a5fbe8a6dc37baeae930db5775290afb2e8a6aecdf13161f1e5b06ef813bc6291d8ee5cefcf1e430c955ea702833a8db84192eebe6e6acf0b9304cb2

情報元 - Merge #20927: [refactor] [net] Clean up InactivityCheck() · bitcoin/[email protected] · GitHub

Merge #20927: [refactor] [net] Clean up InactivityCheck() · bitcoin/bitcoin@32b191f · GitHub
スポンサーリンク

シェアする

フォローする

スポンサーリンク

トップへ戻る