Merge #20186: wallet: Make -wallet setting not create wallets

Merge #20186: wallet: Make -wallet setting not create wallets

01476a88a6095fd3af71cb9bf1eadef920a1197b wallet: Make -wallet setting not create wallets (Russell Yanofsky)

Pull request description:

  This changes `-wallet` setting to only load existing wallets, not create new ones.

  - Fixes settings.json corner cases reported by sjors & promag: https://github.com/bitcoin-core/gui/issues/95, https://github.com/bitcoin/bitcoin/pull/19754#issuecomment-685858578, https://github.com/bitcoin/bitcoin/pull/19754#issuecomment-685858578

  - Prevents accidental creation of wallets reported most recently by jb55 http://www.erisian.com.au/bitcoin-core-dev/log-2020-09-14.html#l-355

  - Simplifies behavior after #15454. #15454 took the big step of disabling creation of the default wallet. This PR extends it to avoid creating other wallets as well. With this change, new wallets just aren't created on startup, instead of sometimes being created, sometimes not. #15454 release notes are updated here and are simpler.

  This change should be targeted for 0.21.0. It's a bug fix and simplifies behavior of the #15937 / #19754 / #15454 features added in 0.21.0.

  ---

  This PR is implementing the simplest, most basic alternative listed in https://github.com/bitcoin-core/gui/issues/95#issuecomment-694236940. Other improvements mentioned there can build on top of this.

ACKs for top commit:
  achow101:
    ACK 01476a88a6095fd3af71cb9bf1eadef920a1197b
  hebasto:
    re-ACK 01476a88a6095fd3af71cb9bf1eadef920a1197b
  MarcoFalke:
    review ACK 01476a88a6095fd3af71cb9bf1eadef920a1197b 🏂

Tree-SHA512: 0d50f4e5dfbd04a2efd9fd66c02085a0ed705807bdec1cf5770d0ae8cb6af07080fb81306349937bf66acdb713d03fb35636f6442b650d0820e66cbae09c2f87

情報元 - Merge #20186: wallet: Make -wallet setting not create wallets · bitcoin/[email protected] · GitHub

Merge #20186: wallet: Make -wallet setting not create wallets · bitcoin/bitcoin@42b66a6 · GitHub
スポンサーリンク

シェアする

フォローする

スポンサーリンク

トップへ戻る