Merge #18388: Make VerifyWitnessProgram use a Span stack

Merge #18388: Make VerifyWitnessProgram use a Span stack

2b0fcff7f26d59fed4bcafd1602325122a206c67 Make VerifyWitnessProgram use a Span stack (Pieter Wuille)

Pull request description:

  Here is a follow-up to #18002, again with the goal of simplifying (potential) BIP341 code.

  Instead of passing a begin and end iterator of the initial stack to `ExecuteWitnessScript`, they are turned into a `Span<const valtype>`, representing a span of `valtype`s in memory. This allows `VerifyWitnessProgram` to operate on that span directly, instead of juggling iterators around (which would be exacerbated by #17977 if trying to avoid copying the stack).

ACKs for top commit:
  ajtowns:
    ACK 2b0fcff7f26d59fed4bcafd1602325122a206c67
  elichai:
    ReACK on the diff 2b0fcff7f26d59fed4bcafd1602325122a206c67
  instagibbs:
    re-ACK https://github.com/bitcoin/bitcoin/pull/18388/commits/2b0fcff7f26d59fed4bcafd1602325122a206c67
  theStack:
    re-ACK https://github.com/bitcoin/bitcoin/commit/2b0fcff7f26d59fed4bcafd1602325122a206c67
  Empact:
    ACK https://github.com/bitcoin/bitcoin/commit/2b0fcff7f26d59fed4bcafd1602325122a206c67
  jnewbery:
    utACK 2b0fcff7f26d59fed4bcafd1602325122a206c67

Tree-SHA512: 38eb4ce17f1947674c1c274caa40feb6ea8266bd96134d9cf1bc41e6fbf1114d4dde6c7a9e26e1ca8f3d0155429ef0911cc8ec0c1037d8fe7d6ec7f9e7184e93

情報元 - Merge #18388: Make VerifyWitnessProgram use a Span stack · bitcoin/[email protected] · GitHub

Merge #18388: Make VerifyWitnessProgram use a Span stack · bitcoin/bitcoin@5464616 · GitHub
スポンサーリンク

シェアする

フォローする

スポンサーリンク

トップへ戻る