Merge #16349: qt: Remove redundant WalletController::addWallet slot

Merge #16349: qt: Remove redundant WalletController::addWallet slot

6285a318d77dbfdf50f893963ebfb2973746f757 Remove redundant WalletController::addWallet slot (Hennadii Stepanov)

Pull request description:

  ~~Fix #15453.~~ It is fixed by https://github.com/bitcoin/bitcoin/pull/16348#issuecomment-509308347

  The _only_ reason of these lines on master (8c69fae94410f54bad13be0f34d54370fddbf4b3)
  https://github.com/bitcoin/bitcoin/blob/2679bb8919b5089f8067ccfd94f766747b8df671/src/qt/walletcontroller.cpp#L121-L128
  is to `Q_EMIT walletAdded(wallet_model);` in a thread-safe manner;

  This PR makes this in a line of code:
  https://github.com/bitcoin/bitcoin/blob/1b83875006749d79916af0197bed65aecdc7ff17/src/qt/walletcontroller.cpp#L121

  EDITED:
  To establish the ownership of a new `WalletModel` object is not necessary on the master (https://github.com/bitcoin/bitcoin/pull/16349#discussion_r301679192 by **promag**).
  But:
  > it's good habit to set ownership

  And I agree. It is a safe practice.

ACKs for top commit:
  promag:
    ACK 6285a318d77dbfdf50f893963ebfb2973746f757.
  jonasschnelli:
    utACK 6285a318d77dbfdf50f893963ebfb2973746f757
  ryanofsky:
    utACK 6285a318d77dbfdf50f893963ebfb2973746f757. Only change since last review is rebasing and restoring a deleted comment. I do think the comments I suggested last review would be better than this one, but this is at least better than before.

Tree-SHA512: 90370cb1fe853b84dd16c3781ba4f97f3f4deca56bba0203e457f37b3220fd13228cf8495fd882ff18b7c782c27544cc2e7a88aaec5b69b9ef6d8626bdaaf332

情報元 - Merge #16349: qt: Remove redundant WalletController::addWallet slot · bitcoin/[email protected] · GitHub

Merge #16349: qt: Remove redundant WalletController::addWallet slot · bitcoin/bitcoin@9059a6f · GitHub
スポンサーリンク

シェアする

フォローする

スポンサーリンク

トップへ戻る